Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signing And Notarizing Plugins Targetting Darwin #45557

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Signing And Notarizing Plugins Targetting Darwin #45557

merged 2 commits into from
Sep 26, 2024

Conversation

doggydogworld
Copy link
Contributor

@doggydogworld doggydogworld commented Aug 16, 2024 •
edited
Loading

Purpose

Plugins that are build for darwin should be signed and notarized.

Implementation

Plugins that build for mac will now include the darwin-signing.mk at the root of the repository and use the function defined there for signing.

codesign -dvv /Users/gusrivera/terraform-provider-teleport
--- terraform-provider-teleport-v16.1.14
+++ terraform-provider-teleport-v17.0.0
Executable=/Users/gusrivera/terraform-provider-teleport
+Identifier=terraform-provider-teleport
-Identifier=a.out
Format=Mach-O thin (x86_64)
+CodeDirectory v=20500 size=672999 flags=0x10000(runtime) hashes=21025+2 location=embedded
-CodeDirectory v=20400 size=311998 flags=0x20002(adhoc,linker-signed) hashes=9747+0 location=embedded
+Signature size=8964
-Signature=adhoc
+Authority=Developer ID Application: Ada Lin (K497G57PDJ)
+Authority=Developer ID Certification Authority
+Authority=Apple Root CA
+Timestamp=Aug 15, 2024 at 5:57:41 PM
Info.plist=not bound
+TeamIdentifier=K497G57PDJ
-TeamIdentifier=not set
+Runtime Version=10.13.0
Sealed Resources=none
Internal requirements count=1 size=188

changelog: Terraform provider plugin and event handler plugin are now signed and notarized for darwin releases.

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

2 similar comments
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

fheinecke
fheinecke approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@fheinecke fheinecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided that this has gone through a dev build with results verified

@doggydogworld
Copy link
Contributor Author

LGTM provided that this has gone through a dev build with results verified

Yeah here's the build: https://github.com/gravitational/teleport.e/actions/runs/10584369974/job/29328496089

It was run using related changes to workflow: https://github.com/gravitational/teleport.e/pull/4944

@doggydogworld doggydogworld added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit ee9b09f Sep 26, 2024
40 checks passed
@doggydogworld doggydogworld deleted the gus/signing-plugins branch September 26, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@fheinecke fheinecke fheinecke approved these changes

Assignees
No one assigned
Labels
size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doggydogworld @r0mant @fheinecke